Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-16 19:43:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

types: fix component *Data types (#7536)

Browse Source
This commit is contained in:
Suneet Tipirneni
2022-02-26 05:17:03 -05:00
committed by GitHub
parent 1a14c0ca56
commit a8321d8026
2 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/discord.js/typings/index.d.ts vendored
View File

@@ -204,7 +204,11 @@ export interface ActionRowData extends BaseComponentData {
} }
export class ActionRow<T extends ActionRowComponent = ActionRowComponent> extends BuilderActionRow<T> { export class ActionRow<T extends ActionRowComponent = ActionRowComponent> extends BuilderActionRow<T> {
constructor(data?: ActionRowData | APIActionRowComponent<APIMessageComponent>); constructor(
data?:
| ActionRowData
| (Omit<APIActionRowComponent<APIMessageComponent>, 'type'> & { type?: ComponentType.ActionRow }),
);
} }
export class ActivityFlagsBitField extends BitField<ActivityFlagsString> { export class ActivityFlagsBitField extends BitField<ActivityFlagsString> {
@@ -473,11 +477,13 @@ export class ButtonInteraction<Cached extends CacheType = CacheType> extends Mes
} }
export class ButtonComponent extends BuilderButtonComponent { export class ButtonComponent extends BuilderButtonComponent {
public constructor(data?: ButtonComponentData | APIButtonComponent); public constructor(data?: ButtonComponentData | (Omit<APIButtonComponent, 'type'> & { type?: ComponentType.Button }));
} }
export class SelectMenuComponent extends BuilderSelectMenuComponent { export class SelectMenuComponent extends BuilderSelectMenuComponent {
public constructor(data?: SelectMenuComponentData | APISelectMenuComponent); public constructor(
data?: SelectMenuComponentData | (Omit<APISelectMenuComponent, 'type'> & { type?: ComponentType.SelectMenu }),
);
} }
export interface EmbedData { export interface EmbedData {
@@ -4619,7 +4625,7 @@ export interface MessageReference {
export type MessageResolvable = Message | Snowflake; export type MessageResolvable = Message | Snowflake;
export interface SelectMenuComponentData extends BaseComponentData { export interface SelectMenuComponentData extends BaseComponentData {
customId?: string; customId: string;
disabled?: boolean; disabled?: boolean;
maxValues?: number; maxValues?: number;
minValues?: number; minValues?: number;

18
packages/discord.js/typings/index.test-d.ts
View File

@@ -103,6 +103,7 @@ import {
ShardEvents, ShardEvents,
Status, Status,
CategoryChannelChildManager, CategoryChannelChildManager,
ActionRowData,
} from '.'; } from '.';
import { expectAssignable, expectDeprecated, expectNotAssignable, expectNotType, expectType } from 'tsd'; import { expectAssignable, expectDeprecated, expectNotAssignable, expectNotType, expectType } from 'tsd';
import { Embed } from '@discordjs/builders'; import { Embed } from '@discordjs/builders';
@@ -1309,6 +1310,23 @@ new ActionRow({
components: [selectMenu.toJSON(), button.toJSON()], components: [selectMenu.toJSON(), button.toJSON()],
}); });
new SelectMenuComponent({
customId: 'foo',
});
new ButtonComponent({
style: ButtonStyle.Danger,
});
expectNotAssignable<ActionRowData>({
type: ComponentType.ActionRow,
components: [
{
type: ComponentType.Button,
},
],
});
declare const chatInputInteraction: ChatInputCommandInteraction; declare const chatInputInteraction: ChatInputCommandInteraction;
expectType<MessageAttachment>(chatInputInteraction.options.getAttachment('attachment', true)); expectType<MessageAttachment>(chatInputInteraction.options.getAttachment('attachment', true));