Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-17 03:53:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(Message): bulkDeletable permissions should be retrieved later for DMs (#9146)

Browse Source 
* fix(Message): permissions check should be done later

the getter will error if used on a message originating from a DM

* refactor: remove unessercary chaining
This commit is contained in:
Sugden
2023-02-25 14:21:53 +00:00
committed by GitHub
parent 4e0e125039
commit a9495bd8f0
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/discord.js/src/structures/Message.js
View File

@@ -645,12 +645,11 @@ class Message extends Base {
* channel.bulkDelete(messages.filter(message => message.bulkDeletable)); * channel.bulkDelete(messages.filter(message => message.bulkDeletable));
*/ */
get bulkDeletable() { get bulkDeletable() {
const permissions = this.channel?.permissionsFor(this.client.user);
return ( return (
(this.inGuild() && (this.inGuild() &&
Date.now() - this.createdTimestamp < MaxBulkDeletableMessageAge && Date.now() - this.createdTimestamp < MaxBulkDeletableMessageAge &&
this.deletable && this.deletable &&
permissions?.has(PermissionFlagsBits.ManageMessages, false)) ?? this.channel?.permissionsFor(this.client.user).has(PermissionFlagsBits.ManageMessages, false)) ??
false false
); );
} }