Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-18 04:23:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: support findLast and reduceRight methods (#9573)

Browse Source 
* feat(collection): findLast and reverseRight

* chore(collection): performance and tests change

Co-authored-by: kyra <kyradiscord@gmail.com>

* remove unnecessary code

* Update packages/collection/src/collection.ts

Co-authored-by: Aura Román <kyradiscord@gmail.com>

* Apply suggestions from code review

Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>

---------

Co-authored-by: kyra <kyradiscord@gmail.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
This commit is contained in:
Jaw0r3k
2023-11-05 19:49:53 +01:00
committed by GitHub
parent c051ed9427
commit ac645084f0
2 changed files with 159 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
packages/collection/__tests__/collection.test.ts
View File

@@ -908,3 +908,73 @@ describe('random thisArg tests', () => {
}, array);
});
});
describe('findLast() tests', () => {
const coll = createTestCollection();
test('it returns last matched element', () => {
expect(coll.findLast((value) => value % 2 === 1)).toStrictEqual(3);
});
test('throws if fn is not a function', () => {
// @ts-expect-error: Invalid function
expectInvalidFunctionError(() => createCollection().findLast());
// @ts-expect-error: Invalid function
expectInvalidFunctionError(() => createCollection().findLast(123), 123);
});
test('binds the thisArg', () => {
coll.findLast(function findLast() {
expect(this).toBeNull();
return true;
}, null);
});
});
describe('findLastKey() tests', () => {
const coll = createTestCollection();
test('it returns last matched element', () => {
expect(coll.findLastKey((value) => value % 2 === 1)).toStrictEqual('c');
});
test('throws if fn is not a function', () => {
// @ts-expect-error: Invalid function
expectInvalidFunctionError(() => createCollection().findLastKey());
// @ts-expect-error: Invalid function
expectInvalidFunctionError(() => createCollection().findLastKey(123), 123);
});
test('binds the thisArg', () => {
coll.findLastKey(function findLastKey() {
expect(this).toBeNull();
return true;
}, null);
});
});
describe('reduceRight() tests', () => {
const coll = createTestCollection();
test('throws if fn is not a function', () => {
// @ts-expect-error: Invalid function
expectInvalidFunctionError(() => coll.reduceRight());
// @ts-expect-error: Invalid function
expectInvalidFunctionError(() => coll.reduceRight(123), 123);
});
test('reduce collection into a single value with initial value', () => {
const sum = coll.reduceRight((a, x) => a + x, 0);
expect(sum).toStrictEqual(6);
});
test('reduce collection into a single value without initial value', () => {
const sum = coll.reduceRight<number>((a, x) => a + x);
expect(sum).toStrictEqual(6);
});
test('reduce empty collection without initial value', () => {
const coll = createCollection();
expect(() => coll.reduceRight((a: number, x) => a + x)).toThrowError(
new TypeError('Reduce of empty collection with no initial value'),
);
});
});