Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-18 12:33:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: destroy options during cleanup (#8082)

Browse Source
This commit is contained in:
Voxelli
2022-06-13 23:33:56 +05:30
committed by GitHub
parent 613fd43fcf
commit afb18b99b7
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/client/websocket/WebSocketShard.js
View File

@@ -367,7 +367,7 @@ class WebSocketShard extends EventEmitter {
if (this.connection) { if (this.connection) {
this._cleanupConnection(); this._cleanupConnection();
// Having this after _cleanupConnection to just clean up the connection and not listen to ws.onclose // Having this after _cleanupConnection to just clean up the connection and not listen to ws.onclose
this.destroy({ reset: true, emit: false, log: false }); this.destroy({ reset: !this.sessionId, emit: false, log: false });
} }
this.status = Status.DISCONNECTED; this.status = Status.DISCONNECTED;
this.emitClose(event); this.emitClose(event);

5
src/util/Options.js
View File

@@ -33,8 +33,9 @@ const process = require('node:process');
* @property {number|number[]|string} [shards] The shard's id to run, or an array of shard ids. If not specified, * @property {number|number[]|string} [shards] The shard's id to run, or an array of shard ids. If not specified,
* the client will spawn {@link ClientOptions#shardCount} shards. If set to `auto`, it will fetch the * the client will spawn {@link ClientOptions#shardCount} shards. If set to `auto`, it will fetch the
* recommended amount of shards from Discord and spawn that amount * recommended amount of shards from Discord and spawn that amount
* @property {number} [closeTimeout=1] The amount of time in milliseconds to wait for the close frame to be received * @property {number} [closeTimeout=5000] The amount of time in milliseconds to wait for the close frame to be received
* from the WebSocket. Don't have this too high/low. Its best to have it between 2_000-6_000 ms. * from the WebSocket.
* <info>Don't have this too high/low. It's best to have it between 2000-6000 ms.</info>
* @property {number} [shardCount=1] The total amount of shards used by all processes of this bot * @property {number} [shardCount=1] The total amount of shards used by all processes of this bot
* (e.g. recommended shard count, shard count of the ShardingManager) * (e.g. recommended shard count, shard count of the ShardingManager)
* @property {CacheFactory} [makeCache] Function to create a cache. * @property {CacheFactory} [makeCache] Function to create a cache.