refactor: make Structure#deleted a getter to a WeakSet (#7074)

src/client/Client.js

@@ -15,7 +15,7 @@ const ClientPresence = require('../structures/ClientPresence');
 const GuildPreview = require('../structures/GuildPreview');
 const GuildTemplate = require('../structures/GuildTemplate');
 const Invite = require('../structures/Invite');
-const Sticker = require('../structures/Sticker');
+const { Sticker } = require('../structures/Sticker');
 const StickerPack = require('../structures/StickerPack');
 const VoiceRegion = require('../structures/VoiceRegion');
 const Webhook = require('../structures/Webhook');

src/client/actions/ChannelDelete.js

@@ -1,7 +1,9 @@
 'use strict';
 
 const Action = require('./Action');
+const { deletedChannels } = require('../../structures/Channel');
 const DMChannel = require('../../structures/DMChannel');
+const { deletedMessages } = require('../../structures/Message');
 const { Events } = require('../../util/Constants');
 
 class ChannelDeleteAction extends Action {
@@ -16,10 +18,10 @@ class ChannelDeleteAction extends Action {
 
     if (channel) {
       client.channels._remove(channel.id);
-      channel.deleted = true;
+      deletedChannels.add(channel);
       if (channel.messages && !(channel instanceof DMChannel)) {
         for (const message of channel.messages.cache.values()) {
-          message.deleted = true;
+          deletedMessages.add(message);
         }
       }
       /**

src/client/actions/ChannelUpdate.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const Action = require('./Action');
-const Channel = require('../../structures/Channel');
+const { Channel } = require('../../structures/Channel');
 const { ChannelTypes } = require('../../util/Constants');
 
 class ChannelUpdateAction extends Action {

src/client/actions/GuildDelete.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const Action = require('./Action');
+const { deletedGuilds } = require('../../structures/Guild');
 const { Events } = require('../../util/Constants');
 
 class GuildDeleteAction extends Action {
@@ -37,7 +38,7 @@ class GuildDeleteAction extends Action {
 
       // Delete guild
       client.guilds.cache.delete(guild.id);
-      guild.deleted = true;
+      deletedGuilds.add(guild);
 
       /**
        * Emitted whenever a guild kicks the client or the guild is deleted/left.

src/client/actions/GuildEmojiDelete.js

@@ -1,12 +1,13 @@
 'use strict';
 
 const Action = require('./Action');
+const { deletedEmojis } = require('../../structures/Emoji');
 const { Events } = require('../../util/Constants');
 
 class GuildEmojiDeleteAction extends Action {
   handle(emoji) {
     emoji.guild.emojis.cache.delete(emoji.id);
-    emoji.deleted = true;
+    deletedEmojis.add(emoji);
     /**
      * Emitted whenever a custom emoji is deleted in a guild.
      * @event Client#emojiDelete

src/client/actions/GuildMemberRemove.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const Action = require('./Action');
+const { deletedGuildMembers } = require('../../structures/GuildMember');
 const { Events, Status } = require('../../util/Constants');
 
 class GuildMemberRemoveAction extends Action {
@@ -12,7 +13,7 @@ class GuildMemberRemoveAction extends Action {
       member = this.getMember({ user: data.user }, guild);
       guild.memberCount--;
       if (member) {
-        member.deleted = true;
+        deletedGuildMembers.add(member);
         guild.members.cache.delete(member.id);
         /**
          * Emitted whenever a member leaves a guild, or is kicked.

src/client/actions/GuildRoleDelete.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const Action = require('./Action');
+const { deletedRoles } = require('../../structures/Role');
 const { Events } = require('../../util/Constants');
 
 class GuildRoleDeleteAction extends Action {
@@ -13,7 +14,7 @@ class GuildRoleDeleteAction extends Action {
       role = guild.roles.cache.get(data.role_id);
       if (role) {
         guild.roles.cache.delete(data.role_id);
-        role.deleted = true;
+        deletedRoles.add(role);
         /**
          * Emitted whenever a guild role is deleted.
          * @event Client#roleDelete

src/client/actions/GuildStickerDelete.js

@@ -1,12 +1,13 @@
 'use strict';
 
 const Action = require('./Action');
+const { deletedStickers } = require('../../structures/Sticker');
 const { Events } = require('../../util/Constants');
 
 class GuildStickerDeleteAction extends Action {
   handle(sticker) {
     sticker.guild.stickers.cache.delete(sticker.id);
-    sticker.deleted = true;
+    deletedStickers.add(sticker);
     /**
      * Emitted whenever a custom sticker is deleted in a guild.
      * @event Client#stickerDelete

src/client/actions/MessageDelete.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const Action = require('./Action');
+const { deletedMessages } = require('../../structures/Message');
 const { Events } = require('../../util/Constants');
 
 class MessageDeleteAction extends Action {
@@ -14,7 +15,7 @@ class MessageDeleteAction extends Action {
       message = this.getMessage(data, channel);
       if (message) {
         channel.messages.cache.delete(message.id);
-        message.deleted = true;
+        deletedMessages.add(message);
         /**
          * Emitted whenever a message is deleted.
          * @event Client#messageDelete

src/client/actions/MessageDeleteBulk.js

@@ -2,6 +2,7 @@
 
 const { Collection } = require('@discordjs/collection');
 const Action = require('./Action');
+const { deletedMessages } = require('../../structures/Message');
 const { Events } = require('../../util/Constants');
 
 class MessageDeleteBulkAction extends Action {
@@ -24,7 +25,7 @@ class MessageDeleteBulkAction extends Action {
           false,
         );
         if (message) {
-          message.deleted = true;
+          deletedMessages.add(message);
           messages.set(message.id, message);
           channel.messages.cache.delete(id);
         }

src/client/actions/StageInstanceDelete.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const Action = require('./Action');
+const { deletedStageInstances } = require('../../structures/StageInstance');
 const { Events } = require('../../util/Constants');
 
 class StageInstanceDeleteAction extends Action {
@@ -12,7 +13,7 @@ class StageInstanceDeleteAction extends Action {
       const stageInstance = channel.guild.stageInstances._add(data);
       if (stageInstance) {
         channel.guild.stageInstances.cache.delete(stageInstance.id);
-        stageInstance.deleted = true;
+        deletedStageInstances.add(stageInstance);
 
         /**
          * Emitted whenever a stage instance is deleted.

src/client/actions/ThreadDelete.js

@@ -1,6 +1,8 @@
 'use strict';
 
 const Action = require('./Action');
+const { deletedChannels } = require('../../structures/Channel');
+const { deletedMessages } = require('../../structures/Message');
 const { Events } = require('../../util/Constants');
 
 class ThreadDeleteAction extends Action {
@@ -10,9 +12,9 @@ class ThreadDeleteAction extends Action {
 
     if (thread) {
       client.channels._remove(thread.id);
-      thread.deleted = true;
+      deletedChannels.add(thread);
       for (const message of thread.messages.cache.values()) {
-        message.deleted = true;
+        deletedMessages.add(message);
       }
 
       /**