sorry gus i borked

This commit is contained in:
Amish Shah
2017-04-29 20:00:05 +01:00
parent 5b2ca326d4
commit b0a3528411
4 changed files with 71 additions and 33 deletions

View File

@@ -0,0 +1,39 @@
/**
* Represents an error from the Discord API
*/
class DiscordAPIError extends Error {
constructor(error) {
super();
const flattened = error.errors ? `\n${this.constructor.flattenErrors(error.errors).join('\n')}` : '';
this.name = 'DiscordAPIError';
this.message = `${error.message}${flattened}`;
/**
* HTTP error code returned by Discord
* @type {number}
*/
this.code = error.code;
}
/**
* Flattens an errors object returned from the API into an array
* @param {Object} obj Discord errors object
* @param {string} [key] idklol
* @returns {string[]}
*/
static flattenErrors(obj, key = '') {
let messages = [];
for (const k of Object.keys(obj)) {
const newKey = key ? isNaN(k) ? `${key}.${k}` : `${key}[${k}]` : k;
if (obj[k]._errors) {
messages.push(`${newKey}: ${obj[k]._errors.map(e => e.message).join(' ')}`);
} else {
messages = messages.concat(this.flattenErrors(obj[k], newKey));
}
}
return messages;
}
}
module.exports = DiscordAPIError;

View File

@@ -1,4 +1,5 @@
const RequestHandler = require('./RequestHandler'); const RequestHandler = require('./RequestHandler');
const DiscordAPIError = require('../DiscordAPIError');
class BurstRequestHandler extends RequestHandler { class BurstRequestHandler extends RequestHandler {
constructor(restManager, endpoint) { constructor(restManager, endpoint) {
@@ -40,7 +41,7 @@ class BurstRequestHandler extends RequestHandler {
this.resetTimeout = null; this.resetTimeout = null;
}, Number(res.headers['retry-after']) + this.client.options.restTimeOffset); }, Number(res.headers['retry-after']) + this.client.options.restTimeOffset);
} else { } else {
item.reject(err); item.reject(err.status === 400 ? new DiscordAPIError(res.body) : err);
this.handle(); this.handle();
} }
} else { } else {

View File

@@ -1,4 +1,5 @@
const RequestHandler = require('./RequestHandler'); const RequestHandler = require('./RequestHandler');
const DiscordAPIError = require('../DiscordAPIError');
/** /**
* Handles API Requests sequentially, i.e. we wait until the current request is finished before moving onto * Handles API Requests sequentially, i.e. we wait until the current request is finished before moving onto
@@ -48,10 +49,7 @@ class SequentialRequestHandler extends RequestHandler {
execute(item) { execute(item) {
this.busy = true; this.busy = true;
return new Promise(resolve => { return new Promise(resolve => {
item.request item.request.gen().end((err, res) => {
.gen()
.on('error', e => item.reject(e))
.end((err, res) => {
if (res && res.headers) { if (res && res.headers) {
this.requestLimit = Number(res.headers['x-ratelimit-limit']); this.requestLimit = Number(res.headers['x-ratelimit-limit']);
this.requestResetTime = Number(res.headers['x-ratelimit-reset']) * 1000; this.requestResetTime = Number(res.headers['x-ratelimit-reset']) * 1000;
@@ -67,7 +65,7 @@ class SequentialRequestHandler extends RequestHandler {
}, Number(res.headers['retry-after']) + this.restManager.client.options.restTimeOffset); }, Number(res.headers['retry-after']) + this.restManager.client.options.restTimeOffset);
if (res.headers['x-ratelimit-global']) this.globalLimit = true; if (res.headers['x-ratelimit-global']) this.globalLimit = true;
} else { } else {
item.reject(err); item.reject(err.status === 400 ? new DiscordAPIError(res.body) : err);
resolve(err); resolve(err);
} }
} else { } else {

View File

@@ -64,7 +64,7 @@ exports.DefaultOptions = {
version: 6, version: 6,
}, },
http: { http: {
version: 6, version: 7,
host: 'https://discordapp.com', host: 'https://discordapp.com',
cdn: 'https://cdn.discordapp.com', cdn: 'https://cdn.discordapp.com',
}, },