Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-15 02:53:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

cleanup: fix deepscan issues (#3740)

Browse Source 
* fix: don't double check if shards are auto.

* fix: remove useless roles array.

* fix: remove useless undefined checks.

* fix: remove useless `this` binding

* Apply suggestions from code review

Co-Authored-By: Sugden <28943913+NotSugden@users.noreply.github.com>

* Fix: Space's suggestion

* Fix: time is always truthy

* Check if it's an invalid date.

Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
This commit is contained in:
Gryffon Bellish
2020-01-24 10:58:23 -05:00
committed by SpaceEEC
parent 929ff9ccd0
commit b81f771007
5 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/client/voice/dispatcher/StreamDispatcher.js
View File

@@ -73,10 +73,10 @@ class StreamDispatcher extends Writable {
this._setSpeaking(0); this._setSpeaking(0);
}); });
if (typeof volume !== 'undefined') this.setVolume(volume); this.setVolume(volume);
this.setBitrate(bitrate);
if (typeof fec !== 'undefined') this.setFEC(fec); if (typeof fec !== 'undefined') this.setFEC(fec);
if (typeof plp !== 'undefined') this.setPLP(plp); if (typeof plp !== 'undefined') this.setPLP(plp);
if (typeof bitrate !== 'undefined') this.setBitrate(bitrate);
const streamError = (type, err) => { const streamError = (type, err) => {
/** /**

2
src/client/websocket/WebSocketManager.js
View File

@@ -158,7 +158,7 @@ class WebSocketManager extends EventEmitter {
if (shards === 'auto') { if (shards === 'auto') {
this.debug(`Using the recommended shard count provided by Discord: ${recommendedShards}`); this.debug(`Using the recommended shard count provided by Discord: ${recommendedShards}`);
this.totalShards = this.client.options.shardCount = recommendedShards; this.totalShards = this.client.options.shardCount = recommendedShards;
if (shards === 'auto' || !this.client.options.shards.length) { if (!this.client.options.shards.length) {
this.client.options.shards = Array.from({ length: recommendedShards }, (_, i) => i); this.client.options.shards = Array.from({ length: recommendedShards }, (_, i) => i);
} }
} }

2
src/client/websocket/handlers/CHANNEL_PINS_UPDATE.js
View File

@@ -6,7 +6,7 @@ module.exports = (client, { d: data }) => {
const channel = client.channels.get(data.channel_id); const channel = client.channels.get(data.channel_id);
const time = new Date(data.last_pin_timestamp); const time = new Date(data.last_pin_timestamp);
if (channel && time) { if (channel && !Number.isNaN(time.getTime())) {
// Discord sends null for last_pin_timestamp if the last pinned message was removed // Discord sends null for last_pin_timestamp if the last pinned message was removed
channel.lastPinTimestamp = time.getTime() || null; channel.lastPinTimestamp = time.getTime() || null;

1
src/structures/Guild.js
View File

@@ -775,6 +775,7 @@ class Guild extends Base {
} }
roles.push(role.id); roles.push(role.id);
} }
options.roles = roles;
} }
return this.client.api.guilds(this.id).members(user).put({ data: options }) return this.client.api.guilds(this.id).members(user).put({ data: options })
.then(data => this.members.add(data)); .then(data => this.members.add(data));

4
src/structures/MessageCollector.js
View File

@@ -36,9 +36,9 @@ class MessageCollector extends Collector {
*/ */
this.received = 0; this.received = 0;
const bulkDeleteListener = (messages => { const bulkDeleteListener = messages => {
for (const message of messages.values()) this.handleDispose(message); for (const message of messages.values()) this.handleDispose(message);
}).bind(this); };
this._handleChannelDeletion = this._handleChannelDeletion.bind(this); this._handleChannelDeletion = this._handleChannelDeletion.bind(this);
this._handleGuildDeletion = this._handleGuildDeletion.bind(this); this._handleGuildDeletion = this._handleGuildDeletion.bind(this);