Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-16 11:33:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(RequestHandler): only reset tokens for authenticated 401s (#7508)

Browse Source
This commit is contained in:
Vlad Frangu
2022-03-06 21:43:12 +02:00
committed by GitHub
parent c12d61a342
commit b9ff7b0573
6 changed files with 50 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/rest/__tests__/REST.test.ts
View File

@@ -245,7 +245,7 @@ test('Request and Response Events', async () => {
method: 'get',
path: '/request',
route: '/request',
data: { files: undefined, body: undefined },
data: { files: undefined, body: undefined, auth: true },
retries: 0,
}) as APIRequest,
);
@@ -254,7 +254,7 @@ test('Request and Response Events', async () => {
method: 'get',
path: '/request',
route: '/request',
data: { files: undefined, body: undefined },
data: { files: undefined, body: undefined, auth: true },
retries: 0,
}) as APIRequest,
expect.objectContaining({ status: 200, statusText: 'OK' }) as Response,

10
packages/rest/__tests__/RequestHandler.test.ts
View File

@@ -357,9 +357,19 @@ test('Bad Request', async () => {
});
test('Unauthorized', async () => {
const setTokenSpy = jest.spyOn(invalidAuthApi.requestManager, 'setToken');
// Ensure authless requests don't reset the token
const promiseWithoutTokenClear = invalidAuthApi.get('/unauthorized', { auth: false });
await expect(promiseWithoutTokenClear).rejects.toThrowError('401: Unauthorized');
await expect(promiseWithoutTokenClear).rejects.toBeInstanceOf(DiscordAPIError);
expect(setTokenSpy).not.toHaveBeenCalled();
// Ensure authed requests do reset the token
const promise = invalidAuthApi.get('/unauthorized');
await expect(promise).rejects.toThrowError('401: Unauthorized');
await expect(promise).rejects.toBeInstanceOf(DiscordAPIError);
expect(setTokenSpy).toHaveBeenCalledTimes(1);
});
test('Reject on RateLimit', async () => {