From bf738b34de1f02f83b4ddb3f60f3947840db91e7 Mon Sep 17 00:00:00 2001 From: Mikhail Date: Sat, 23 Jun 2018 16:20:59 +0300 Subject: [PATCH] fix(BasePlayer): incorrectly mutating FFMPEG_ARGUMENTS when using seek (#2622) Because args was not a copy of FFMPEG_ARGIMENTS, but a reference to it, pushing 'ss' argument pushed it to FFMPEG_ARGUMENTS, making it persistent. --- src/client/voice/player/BasePlayer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/client/voice/player/BasePlayer.js b/src/client/voice/player/BasePlayer.js index a8889e44a..e19984dff 100644 --- a/src/client/voice/player/BasePlayer.js +++ b/src/client/voice/player/BasePlayer.js @@ -45,7 +45,7 @@ class BasePlayer extends EventEmitter { const isStream = input instanceof ReadableStream; - const args = isStream ? FFMPEG_ARGUMENTS : ['-i', input, ...FFMPEG_ARGUMENTS]; + const args = isStream ? FFMPEG_ARGUMENTS.slice() : ['-i', input, ...FFMPEG_ARGUMENTS]; if (options.seek) args.push('-ss', String(options.seek)); const ffmpeg = new prism.FFmpeg({ args });