Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-15 02:53:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

perf(RoleManager): dont call Role#position getter twice per role (#9352)

Browse Source 
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This commit is contained in:
Almeida
2023-04-09 11:29:18 +01:00
committed by GitHub
parent fbbce3eb4b
commit bfee6c8d88
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/discord.js/src/managers/RoleManager.js
View File

@@ -307,11 +307,14 @@ class RoleManager extends CachedManager {
throw new DiscordjsTypeError(ErrorCodes.InvalidType, 'role', 'Role nor a Snowflake'); throw new DiscordjsTypeError(ErrorCodes.InvalidType, 'role', 'Role nor a Snowflake');
} }
if (resolvedRole1.position === resolvedRole2.position) { const role1Position = resolvedRole1.position;
const role2Position = resolvedRole2.position;
if (role1Position === role2Position) {
return Number(BigInt(resolvedRole2.id) - BigInt(resolvedRole1.id)); return Number(BigInt(resolvedRole2.id) - BigInt(resolvedRole1.id));
} }
return resolvedRole1.position - resolvedRole2.position; return role1Position - role2Position;
} }
/** /**