Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-13 10:03:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

voice: remove passes

Browse Source 
(discord will begin dropping duplicated audio packets from tomorrow, you should not set passes > 1)
This commit is contained in:
Amish Shah
2019-08-22 12:15:20 +01:00
parent cc488a8bd3
commit c715ed9f8b
4 changed files with 11 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/client/voice/dispatcher/StreamDispatcher.js
View File

@@ -33,9 +33,9 @@ const nonce = Buffer.alloc(24);
class StreamDispatcher extends Writable {
constructor(
player,
{ seek = 0, volume = 1, passes = 1, fec, plp, bitrate = 96, highWaterMark = 12 } = {},
{ seek = 0, volume = 1, fec, plp, bitrate = 96, highWaterMark = 12 } = {},
streams) {
const streamOptions = { seek, volume, passes, fec, plp, bitrate, highWaterMark };
const streamOptions = { seek, volume, fec, plp, bitrate, highWaterMark };
super(streamOptions);
/**
* The Audio Player that controls this dispatcher
@@ -289,24 +289,21 @@ class StreamDispatcher extends Writable {
}
_sendPacket(packet) {
let repeats = this.streamOptions.passes;
/**
* Emitted whenever the dispatcher has debug information.
* @event StreamDispatcher#debug
* @param {string} info The debug info
*/
this._setSpeaking(1);
while (repeats--) {
if (!this.player.voiceConnection.sockets.udp) {
this.emit('debug', 'Failed to send a packet - no UDP socket');
return;
}
this.player.voiceConnection.sockets.udp.send(packet)
.catch(e => {
this._setSpeaking(0);
this.emit('debug', `Failed to send a packet - ${e}`);
});
if (!this.player.voiceConnection.sockets.udp) {
this.emit('debug', 'Failed to send a packet - no UDP socket');
return;
}
this.player.voiceConnection.sockets.udp.send(packet)
.catch(e => {
this._setSpeaking(0);
this.emit('debug', `Failed to send a packet - ${e}`);
});
}
_setSpeaking(value) {

1
src/client/voice/util/PlayInterface.js
View File

@@ -11,7 +11,6 @@ const { Error } = require('../../../errors');
* @property {number} [seek=0] The time to seek to, will be ignored when playing `ogg/opus` or `webm/opus` streams
* @property {number|boolean} [volume=1] The volume to play at. Set this to false to disable volume transforms for
* this stream to improve performance.
* @property {number} [passes=1] How many times to send the voice packet to reduce packet loss
* @property {number} [plp] Expected packet loss percentage
* @property {boolean} [fec] Enabled forward error correction
* @property {number|string} [bitrate=96] The bitrate (quality) of the audio in kbps.