From cd08a3b5a4569e98aaa9c954d578ac9c12fba826 Mon Sep 17 00:00:00 2001 From: SpaceEEC Date: Thu, 26 Oct 2017 09:52:03 +0200 Subject: [PATCH] refactor(Actions): remove obsolete user and guild member get actions (#2061) The UserGetAction was never used. The GuildMemberGetAction was only once used. Easily replaced with a shorter and more comprehensible line. (Also consistent with the rest of the library) --- src/client/actions/ActionsManager.js | 2 -- src/client/actions/GuildMemberGet.js | 10 ---------- src/client/actions/UserGet.js | 11 ----------- src/structures/Guild.js | 2 +- 4 files changed, 1 insertion(+), 24 deletions(-) delete mode 100644 src/client/actions/GuildMemberGet.js delete mode 100644 src/client/actions/UserGet.js diff --git a/src/client/actions/ActionsManager.js b/src/client/actions/ActionsManager.js index 8341e7453..9708d17b2 100644 --- a/src/client/actions/ActionsManager.js +++ b/src/client/actions/ActionsManager.js @@ -14,13 +14,11 @@ class ActionsManager { this.register(require('./ChannelUpdate')); this.register(require('./GuildDelete')); this.register(require('./GuildUpdate')); - this.register(require('./GuildMemberGet')); this.register(require('./GuildMemberRemove')); this.register(require('./GuildBanRemove')); this.register(require('./GuildRoleCreate')); this.register(require('./GuildRoleDelete')); this.register(require('./GuildRoleUpdate')); - this.register(require('./UserGet')); this.register(require('./UserUpdate')); this.register(require('./UserNoteUpdate')); this.register(require('./GuildSync')); diff --git a/src/client/actions/GuildMemberGet.js b/src/client/actions/GuildMemberGet.js deleted file mode 100644 index 5bf2aafec..000000000 --- a/src/client/actions/GuildMemberGet.js +++ /dev/null @@ -1,10 +0,0 @@ -const Action = require('./Action'); - -class GuildMemberGetAction extends Action { - handle(guild, data) { - const member = guild.members.create(data); - return { member }; - } -} - -module.exports = GuildMemberGetAction; diff --git a/src/client/actions/UserGet.js b/src/client/actions/UserGet.js deleted file mode 100644 index 4a135dd58..000000000 --- a/src/client/actions/UserGet.js +++ /dev/null @@ -1,11 +0,0 @@ -const Action = require('./Action'); - -class UserGetAction extends Action { - handle(data) { - const client = this.client; - const user = client.users.create(data); - return { user }; - } -} - -module.exports = UserGetAction; diff --git a/src/structures/Guild.js b/src/structures/Guild.js index d96329be0..b3ea8535d 100644 --- a/src/structures/Guild.js +++ b/src/structures/Guild.js @@ -542,7 +542,7 @@ class Guild extends Base { } } return this.client.api.guilds(this.id).members(user.id).put({ data: options }) - .then(data => this.client.actions.GuildMemberGet.handle(this, data).member); + .then(data => this.members.create(data)); } /**