Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-18 04:23:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(GuildMember#hasPermission): pass correct parameters to Permissions#has (#2070)

Browse Source 
Also removed deprecated parameter of the method itself.
This commit is contained in:
SpaceEEC
2017-10-28 18:57:16 +02:00
committed by Crawl
parent 0a05761b49
commit cd3d3344e8
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/structures/GuildMember.js
View File

@@ -294,19 +294,13 @@ class GuildMember extends Base {
/** /**
* Checks if any of the member's roles have a permission. * Checks if any of the member's roles have a permission.
* @param {PermissionResolvable|PermissionResolvable[]} permission Permission(s) to check for * @param {PermissionResolvable|PermissionResolvable[]} permission Permission(s) to check for
* @param {boolean} [explicit=false] Whether to require the role to explicitly have the exact permission * @param {boolean} [checkAdmin=true] Whether to allow the administrator permission to override
* **(deprecated)** * @param {boolean} [checkOwner=true] Whether to allow being the guild's owner to override
* @param {boolean} [checkAdmin] Whether to allow the administrator permission to override
* (takes priority over `explicit`)
* @param {boolean} [checkOwner] Whether to allow being the guild's owner to override
* (takes priority over `explicit`)
* @returns {boolean} * @returns {boolean}
*/ */
hasPermission(permission, explicit = false, checkAdmin, checkOwner) { hasPermission(permission, checkAdmin = true, checkOwner = true) {
if (typeof checkAdmin === 'undefined') checkAdmin = !explicit;
if (typeof checkOwner === 'undefined') checkOwner = !explicit;
if (checkOwner && this.user.id === this.guild.ownerID) return true; if (checkOwner && this.user.id === this.guild.ownerID) return true;
return this.roles.some(r => r.permissions.has(permission, undefined, checkAdmin)); return this.roles.some(r => r.permissions.has(permission, checkAdmin));
} }
/** /**