Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-17 20:13:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: use new permission name (#9274)

Browse Source 
* fix: use new permission name

* docs: requested changes

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This commit is contained in:
Almeida
2023-04-19 15:32:07 +01:00
committed by GitHub
parent 603446a692
commit d2d27ce734
5 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/discord.js/src/errors/ErrorCodes.js
View File

@@ -106,7 +106,10 @@
* @property {'EmojiType'} EmojiType * @property {'EmojiType'} EmojiType
* @property {'EmojiManaged'} EmojiManaged * @property {'EmojiManaged'} EmojiManaged
* @property {'MissingManageGuildExpressionsPermission'} MissingManageGuildExpressionsPermission
* @property {'MissingManageEmojisAndStickersPermission'} MissingManageEmojisAndStickersPermission * @property {'MissingManageEmojisAndStickersPermission'} MissingManageEmojisAndStickersPermission
* <warn>This property is deprecated. Use `MissingManageGuildExpressionsPermission` instead.</warn>
*
* @property {'NotGuildSticker'} NotGuildSticker * @property {'NotGuildSticker'} NotGuildSticker
* @property {'ReactionResolveUser'} ReactionResolveUser * @property {'ReactionResolveUser'} ReactionResolveUser
@@ -255,7 +258,9 @@ const keys = [
'EmojiType', 'EmojiType',
'EmojiManaged', 'EmojiManaged',
'MissingManageGuildExpressionsPermission',
'MissingManageEmojisAndStickersPermission', 'MissingManageEmojisAndStickersPermission',
'NotGuildSticker', 'NotGuildSticker',
'ReactionResolveUser', 'ReactionResolveUser',

3
packages/discord.js/src/errors/Messages.js
View File

@@ -111,8 +111,11 @@ const Messages = {
[DjsErrorCodes.EmojiType]: 'Emoji must be a string or GuildEmoji/ReactionEmoji', [DjsErrorCodes.EmojiType]: 'Emoji must be a string or GuildEmoji/ReactionEmoji',
[DjsErrorCodes.EmojiManaged]: 'Emoji is managed and has no Author.', [DjsErrorCodes.EmojiManaged]: 'Emoji is managed and has no Author.',
[DjsErrorCodes.MissingManageGuildExpressionsPermission]: guild =>
`Client must have Manage Guild Expressions permission in guild ${guild} to see emoji authors.`,
[DjsErrorCodes.MissingManageEmojisAndStickersPermission]: guild => [DjsErrorCodes.MissingManageEmojisAndStickersPermission]: guild =>
`Client must have Manage Emojis and Stickers permission in guild ${guild} to see emoji authors.`, `Client must have Manage Emojis and Stickers permission in guild ${guild} to see emoji authors.`,
[DjsErrorCodes.NotGuildSticker]: 'Sticker is a standard (non-guild) sticker and has no author.', [DjsErrorCodes.NotGuildSticker]: 'Sticker is a standard (non-guild) sticker and has no author.',
[DjsErrorCodes.ReactionResolveUser]: "Couldn't resolve the user id to remove from the reaction.", [DjsErrorCodes.ReactionResolveUser]: "Couldn't resolve the user id to remove from the reaction.",

4
packages/discord.js/src/managers/GuildEmojiManager.js
View File

@@ -161,8 +161,8 @@ class GuildEmojiManager extends BaseGuildEmojiManager {
const { me } = this.guild.members; const { me } = this.guild.members;
if (!me) throw new DiscordjsError(ErrorCodes.GuildUncachedMe); if (!me) throw new DiscordjsError(ErrorCodes.GuildUncachedMe);
if (!me.permissions.has(PermissionFlagsBits.ManageEmojisAndStickers)) { if (!me.permissions.has(PermissionFlagsBits.ManageGuildExpressions)) {
throw new DiscordjsError(ErrorCodes.MissingManageEmojisAndStickersPermission, this.guild); throw new DiscordjsError(ErrorCodes.MissingManageGuildExpressionsPermission, this.guild);
} }
const data = await this.client.rest.get(Routes.guildEmoji(this.guild.id, emoji.id)); const data = await this.client.rest.get(Routes.guildEmoji(this.guild.id, emoji.id));

2
packages/discord.js/src/structures/GuildEmoji.js
View File

@@ -56,7 +56,7 @@ class GuildEmoji extends BaseGuildEmoji {
*/ */
get deletable() { get deletable() {
if (!this.guild.members.me) throw new DiscordjsError(ErrorCodes.GuildUncachedMe); if (!this.guild.members.me) throw new DiscordjsError(ErrorCodes.GuildUncachedMe);
return !this.managed && this.guild.members.me.permissions.has(PermissionFlagsBits.ManageEmojisAndStickers); return !this.managed && this.guild.members.me.permissions.has(PermissionFlagsBits.ManageGuildExpressions);
} }
/** /**

3
packages/discord.js/typings/index.d.ts vendored
View File

@@ -3601,7 +3601,10 @@ export enum DiscordjsErrorCodes {
EmojiType = 'EmojiType', EmojiType = 'EmojiType',
EmojiManaged = 'EmojiManaged', EmojiManaged = 'EmojiManaged',
MissingManageGuildExpressionsPermission = 'MissingManageGuildExpressionsPermission',
/** @deprecated Use {@link MissingManageGuildExpressionsPermission} instead. */
MissingManageEmojisAndStickersPermission = 'MissingManageEmojisAndStickersPermission', MissingManageEmojisAndStickersPermission = 'MissingManageEmojisAndStickersPermission',
NotGuildSticker = 'NotGuildSticker', NotGuildSticker = 'NotGuildSticker',
ReactionResolveUser = 'ReactionResolveUser', ReactionResolveUser = 'ReactionResolveUser',