From dd31ee0c5fd04ec3436da93a9e76660499c0b211 Mon Sep 17 00:00:00 2001 From: isonmad Date: Thu, 27 Oct 2016 06:33:51 -0400 Subject: [PATCH] propagate errors in ClientManager.destroy (#844) If the promise returned by logout() rejects, previously it would be completely uncaught, and just return an eternally pending promise that never resolved. Related to pull requests #828 and #839. --- src/client/ClientManager.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/client/ClientManager.js b/src/client/ClientManager.js index 03d43b375..ef943b339 100644 --- a/src/client/ClientManager.js +++ b/src/client/ClientManager.js @@ -58,10 +58,10 @@ class ClientManager { } destroy() { - return new Promise((resolve) => { + return new Promise((resolve, reject) => { this.client.ws.destroy(); if (!this.client.user.bot) { - this.client.rest.methods.logout().then(resolve); + this.client.rest.methods.logout().then(resolve, reject); } else { resolve(); }