From defeee5eecdcbf77fa8a5394ac8edd2c895defcc Mon Sep 17 00:00:00 2001 From: Neutron <120790871+Shiva953@users.noreply.github.com> Date: Wed, 8 Nov 2023 06:58:27 +0530 Subject: [PATCH] feat: return entries instead of values in toJSON method (#9345) * feat(collection): return entries instead of values in toJSON method * test: adjust test --------- Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> --- packages/collection/__tests__/collection.test.ts | 9 +++++++-- packages/collection/src/collection.ts | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/collection/__tests__/collection.test.ts b/packages/collection/__tests__/collection.test.ts index 26843dce1..f3c80c31d 100644 --- a/packages/collection/__tests__/collection.test.ts +++ b/packages/collection/__tests__/collection.test.ts @@ -828,9 +828,14 @@ describe('tap() tests', () => { }); describe('toJSON() tests', () => { - test('it returns the values as an array', () => { + test('it returns the entries of the collection', () => { const c = createTestCollection(); - expect(c.toJSON()).toStrictEqual([1, 2, 3]); + + expect(c.toJSON()).toStrictEqual([ + ['a', 1], + ['b', 2], + ['c', 3], + ]); }); }); diff --git a/packages/collection/src/collection.ts b/packages/collection/src/collection.ts index 93bfc950a..fcee69f7f 100644 --- a/packages/collection/src/collection.ts +++ b/packages/collection/src/collection.ts @@ -933,7 +933,7 @@ export class Collection extends Map { public toJSON() { // toJSON is called recursively by JSON.stringify. - return [...this.values()]; + return [...this.entries()]; } private static defaultSort(firstValue: V, secondValue: V): number {