Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-17 12:03:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(MessageEmbed): correct docs, default to array, resolve MessageAttachments (#2492)

Browse Source 
* Fix(MessageEmbed): Remove useless for...of & change this.files to be out of the data.files check...

* Requested changes
This commit is contained in:
Jacz
2018-04-24 03:38:56 +10:00
committed by SpaceEEC
parent b186472785
commit e12ab7428f
1 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/structures/MessageEmbed.js
View File

@@ -132,12 +132,13 @@ class MessageEmbed {
proxyIconURL: data.footer.proxyIconURL || data.footer.proxy_icon_url, proxyIconURL: data.footer.proxyIconURL || data.footer.proxy_icon_url,
} : null; } : null;
/**
* The files of this embed
* @type {Array<FileOptions|string|MessageAttachment>}
*/
this.files = [];
if (data.files) { if (data.files) {
/**
* The files of this embed
* @type {?Object}
* @property {Array<FileOptions|string|MessageAttachment>} files Files to attach
*/
this.files = data.files.map(file => { this.files = data.files.map(file => {
if (file instanceof MessageAttachment) { if (file instanceof MessageAttachment) {
return typeof file.file === 'string' ? file.file : Util.cloneObject(file.file); return typeof file.file === 'string' ? file.file : Util.cloneObject(file.file);
@@ -198,11 +199,8 @@ class MessageEmbed {
* @returns {MessageEmbed} * @returns {MessageEmbed}
*/ */
attachFiles(files) { attachFiles(files) {
if (this.files) this.files = this.files.concat(files); files = files.map(file => file instanceof MessageAttachment ? file.file : file);
else this.files = files; this.files = this.files.concat(files);
for (let file of files) {
if (file instanceof MessageAttachment) file = file.file;
}
return this; return this;
} }