refactor: use eslint-config-neon for packages. (#8579)

Co-authored-by: Noel <buechler.noel@outlook.com>

packages/rest/src/lib/REST.ts

@@ -1,19 +1,19 @@
 import { EventEmitter } from 'node:events';
 import type { Collection } from '@discordjs/collection';
 import type { request, Dispatcher } from 'undici';
-import { CDN } from './CDN';
+import { CDN } from './CDN.js';
 import {
-	HandlerRequestData,
-	InternalRequest,
-	RequestData,
 	RequestManager,
 	RequestMethod,
-	RouteLike,
-} from './RequestManager';
-import type { HashData } from './RequestManager';
+	type HashData,
+	type HandlerRequestData,
+	type InternalRequest,
+	type RequestData,
+	type RouteLike,
+} from './RequestManager.js';
 import type { IHandler } from './handlers/IHandler';
-import { DefaultRestOptions, RESTEvents } from './utils/constants';
-import { parseResponse } from './utils/utils';
+import { DefaultRestOptions, RESTEvents } from './utils/constants.js';
+import { parseResponse } from './utils/utils.js';
 
 /**
  * Options to be passed when creating the REST instance
@@ -25,6 +25,7 @@ export interface RESTOptions {
 	agent: Dispatcher;
 	/**
 	 * The base api path, without version
+	 *
 	 * @defaultValue `'https://discord.com/api'`
 	 */
 	api: string;
@@ -34,13 +35,37 @@ export interface RESTOptions {
 	 *
 	 * @defaultValue `'Bot'`
 	 */
-	authPrefix: 'Bot' | 'Bearer';
+	authPrefix: 'Bearer' | 'Bot';
 	/**
 	 * The cdn path
 	 *
 	 * @defaultValue 'https://cdn.discordapp.com'
 	 */
 	cdn: string;
+	/**
+	 * How many requests to allow sending per second (Infinity for unlimited, 50 for the standard global limit used by Discord)
+	 *
+	 * @defaultValue `50`
+	 */
+	globalRequestsPerSecond: number;
+	/**
+	 * The amount of time in milliseconds that passes between each hash sweep. (defaults to 1h)
+	 *
+	 * @defaultValue `3_600_000`
+	 */
+	handlerSweepInterval: number;
+	/**
+	 * The maximum amount of time a hash can exist in milliseconds without being hit with a request (defaults to 24h)
+	 *
+	 * @defaultValue `86_400_000`
+	 */
+	hashLifetime: number;
+	/**
+	 * The amount of time in milliseconds that passes between each hash sweep. (defaults to 4h)
+	 *
+	 * @defaultValue `14_400_000`
+	 */
+	hashSweepInterval: number;
 	/**
 	 * Additional headers to send for all API requests
 	 *
@@ -54,12 +79,6 @@ export interface RESTOptions {
 	 * @defaultValue `0`
 	 */
 	invalidRequestWarningInterval: number;
-	/**
-	 * How many requests to allow sending per second (Infinity for unlimited, 50 for the standard global limit used by Discord)
-	 *
-	 * @defaultValue `50`
-	 */
-	globalRequestsPerSecond: number;
 	/**
 	 * The extra offset to add to rate limits in milliseconds
 	 *
@@ -74,7 +93,7 @@ export interface RESTOptions {
 	 *
 	 * @defaultValue `null`
 	 */
-	rejectOnRateLimit: string[] | RateLimitQueueFilter | null;
+	rejectOnRateLimit: RateLimitQueueFilter | string[] | null;
 	/**
 	 * The number of retries for errors with the 500 code, or errors
 	 * that timeout
@@ -100,24 +119,6 @@ export interface RESTOptions {
 	 * @defaultValue `'10'`
 	 */
 	version: string;
-	/**
-	 * The amount of time in milliseconds that passes between each hash sweep. (defaults to 4h)
-	 *
-	 * @defaultValue `14_400_000`
-	 */
-	hashSweepInterval: number;
-	/**
-	 * The maximum amount of time a hash can exist in milliseconds without being hit with a request (defaults to 24h)
-	 *
-	 * @defaultValue `86_400_000`
-	 */
-	hashLifetime: number;
-	/**
-	 * The amount of time in milliseconds that passes between each hash sweep. (defaults to 1h)
-	 *
-	 * @defaultValue `3_600_000`
-	 */
-	handlerSweepInterval: number;
 }
 
 /**
@@ -125,29 +126,17 @@ export interface RESTOptions {
  */
 export interface RateLimitData {
 	/**
-	 * The time, in milliseconds, until the request-lock is reset
+	 * Whether the rate limit that was reached was the global limit
 	 */
-	timeToReset: number;
-	/**
-	 * The amount of requests we can perform before locking requests
-	 */
-	limit: number;
-	/**
-	 * The HTTP method being performed
-	 */
-	method: string;
+	global: boolean;
 	/**
 	 * The bucket hash for this request
 	 */
 	hash: string;
 	/**
-	 * The full URL for this request
+	 * The amount of requests we can perform before locking requests
 	 */
-	url: string;
-	/**
-	 * The route being hit in this request
-	 */
-	route: string;
+	limit: number;
 	/**
 	 * The major parameter of the route
 	 *
@@ -156,41 +145,53 @@ export interface RateLimitData {
 	 */
 	majorParameter: string;
 	/**
-	 * Whether the rate limit that was reached was the global limit
+	 * The HTTP method being performed
 	 */
-	global: boolean;
+	method: string;
+	/**
+	 * The route being hit in this request
+	 */
+	route: string;
+	/**
+	 * The time, in milliseconds, until the request-lock is reset
+	 */
+	timeToReset: number;
+	/**
+	 * The full URL for this request
+	 */
+	url: string;
 }
 
 /**
  * A function that determines whether the rate limit hit should throw an Error
  */
-export type RateLimitQueueFilter = (rateLimitData: RateLimitData) => boolean | Promise<boolean>;
+export type RateLimitQueueFilter = (rateLimitData: RateLimitData) => Promise<boolean> | boolean;
 
 export interface APIRequest {
-	/**
-	 * The HTTP method used in this request
-	 */
-	method: string;
-	/**
-	 * The full path used to make the request
-	 */
-	path: RouteLike;
-	/**
-	 * The API route identifying the ratelimit for this request
-	 */
-	route: string;
-	/**
-	 * Additional HTTP options for this request
-	 */
-	options: RequestOptions;
 	/**
 	 * The data that was used to form the body of this request
 	 */
 	data: HandlerRequestData;
+	/**
+	 * The HTTP method used in this request
+	 */
+	method: string;
+	/**
+	 * Additional HTTP options for this request
+	 */
+	options: RequestOptions;
+	/**
+	 * The full path used to make the request
+	 */
+	path: RouteLike;
 	/**
 	 * The number of times this request has been attempted
 	 */
 	retries: number;
+	/**
+	 * The API route identifying the ratelimit for this request
+	 */
+	route: string;
 }
 
 export interface InvalidRequestWarningData {
@@ -205,29 +206,29 @@ export interface InvalidRequestWarningData {
 }
 
 export interface RestEvents {
-	invalidRequestWarning: [invalidRequestInfo: InvalidRequestWarningData];
-	restDebug: [info: string];
-	rateLimited: [rateLimitInfo: RateLimitData];
-	response: [request: APIRequest, response: Dispatcher.ResponseData];
-	newListener: [name: string, listener: (...args: any) => void];
-	removeListener: [name: string, listener: (...args: any) => void];
-	hashSweep: [sweptHashes: Collection<string, HashData>];
 	handlerSweep: [sweptHandlers: Collection<string, IHandler>];
+	hashSweep: [sweptHashes: Collection<string, HashData>];
+	invalidRequestWarning: [invalidRequestInfo: InvalidRequestWarningData];
+	newListener: [name: string, listener: (...args: any) => void];
+	rateLimited: [rateLimitInfo: RateLimitData];
+	removeListener: [name: string, listener: (...args: any) => void];
+	response: [request: APIRequest, response: Dispatcher.ResponseData];
+	restDebug: [info: string];
 }
 
 export interface REST {
-	on: (<K extends keyof RestEvents>(event: K, listener: (...args: RestEvents[K]) => void) => this) &
-		(<S extends string | symbol>(event: Exclude<S, keyof RestEvents>, listener: (...args: any[]) => void) => this);
-
-	once: (<K extends keyof RestEvents>(event: K, listener: (...args: RestEvents[K]) => void) => this) &
-		(<S extends string | symbol>(event: Exclude<S, keyof RestEvents>, listener: (...args: any[]) => void) => this);
-
 	emit: (<K extends keyof RestEvents>(event: K, ...args: RestEvents[K]) => boolean) &
 		(<S extends string | symbol>(event: Exclude<S, keyof RestEvents>, ...args: any[]) => boolean);
 
 	off: (<K extends keyof RestEvents>(event: K, listener: (...args: RestEvents[K]) => void) => this) &
 		(<S extends string | symbol>(event: Exclude<S, keyof RestEvents>, listener: (...args: any[]) => void) => this);
 
+	on: (<K extends keyof RestEvents>(event: K, listener: (...args: RestEvents[K]) => void) => this) &
+		(<S extends string | symbol>(event: Exclude<S, keyof RestEvents>, listener: (...args: any[]) => void) => this);
+
+	once: (<K extends keyof RestEvents>(event: K, listener: (...args: RestEvents[K]) => void) => this) &
+		(<S extends string | symbol>(event: Exclude<S, keyof RestEvents>, listener: (...args: any[]) => void) => this);
+
 	removeAllListeners: (<K extends keyof RestEvents>(event?: K) => this) &
 		(<S extends string | symbol>(event?: Exclude<S, keyof RestEvents>) => this);
 }
@@ -236,6 +237,7 @@ export type RequestOptions = Exclude<Parameters<typeof request>[1], undefined>;
 
 export class REST extends EventEmitter {
 	public readonly cdn: CDN;
+
 	public readonly requestManager: RequestManager;
 
 	public constructor(options: Partial<RESTOptions> = {}) {
@@ -288,7 +290,7 @@ export class REST extends EventEmitter {
 	 * @param fullRoute - The full route to query
 	 * @param options - Optional request options
 	 */
-	public get(fullRoute: RouteLike, options: RequestData = {}) {
+	public async get(fullRoute: RouteLike, options: RequestData = {}) {
 		return this.request({ ...options, fullRoute, method: RequestMethod.Get });
 	}
 
@@ -298,7 +300,7 @@ export class REST extends EventEmitter {
 	 * @param fullRoute - The full route to query
 	 * @param options - Optional request options
 	 */
-	public delete(fullRoute: RouteLike, options: RequestData = {}) {
+	public async delete(fullRoute: RouteLike, options: RequestData = {}) {
 		return this.request({ ...options, fullRoute, method: RequestMethod.Delete });
 	}
 
@@ -308,7 +310,7 @@ export class REST extends EventEmitter {
 	 * @param fullRoute - The full route to query
 	 * @param options - Optional request options
 	 */
-	public post(fullRoute: RouteLike, options: RequestData = {}) {
+	public async post(fullRoute: RouteLike, options: RequestData = {}) {
 		return this.request({ ...options, fullRoute, method: RequestMethod.Post });
 	}
 
@@ -318,7 +320,7 @@ export class REST extends EventEmitter {
 	 * @param fullRoute - The full route to query
 	 * @param options - Optional request options
 	 */
-	public put(fullRoute: RouteLike, options: RequestData = {}) {
+	public async put(fullRoute: RouteLike, options: RequestData = {}) {
 		return this.request({ ...options, fullRoute, method: RequestMethod.Put });
 	}
 
@@ -328,7 +330,7 @@ export class REST extends EventEmitter {
 	 * @param fullRoute - The full route to query
 	 * @param options - Optional request options
 	 */
-	public patch(fullRoute: RouteLike, options: RequestData = {}) {
+	public async patch(fullRoute: RouteLike, options: RequestData = {}) {
 		return this.request({ ...options, fullRoute, method: RequestMethod.Patch });
 	}
 
@@ -347,7 +349,7 @@ export class REST extends EventEmitter {
 	 *
 	 * @param options - Request options
 	 */
-	public raw(options: InternalRequest) {
+	public async raw(options: InternalRequest) {
 		return this.requestManager.queueRequest(options);
 	}
 }