From f2fdb9331895da59546107efe245a2e0137ef2e7 Mon Sep 17 00:00:00 2001 From: Ryan Munro Date: Mon, 23 Mar 2020 18:36:27 +1100 Subject: [PATCH] =?UTF-8?q?fix(Typings):=20client=20message=20event=20shou?= =?UTF-8?q?ld=20not=20emit=20PartialMessa=E2=80=A6=20(#3983)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix(Typings): client message event should not emit PartialMessage * Update typings/index.d.ts Co-Authored-By: Jyguy Co-authored-by: Crawl Co-authored-by: Jyguy --- typings/index.d.ts | 49 ++++++++++++++++------------------------------ 1 file changed, 17 insertions(+), 32 deletions(-) diff --git a/typings/index.d.ts b/typings/index.d.ts index 2ec7a8385..5c09205e9 100644 --- a/typings/index.d.ts +++ b/typings/index.d.ts @@ -2164,7 +2164,7 @@ declare module 'discord.js' { guildUpdate: [Guild, Guild]; inviteCreate: [Invite]; inviteDelete: [Invite]; - message: [Message | PartialMessage]; + message: [Message]; messageDelete: [Message | PartialMessage]; messageReactionRemoveAll: [Message | PartialMessage]; messageReactionRemoveEmoji: [MessageReaction]; @@ -2784,19 +2784,14 @@ declare module 'discord.js' { [K in keyof Omit< T, 'client' | 'createdAt' | 'createdTimestamp' | 'id' | 'partial' | 'fetch' | O - >]: // tslint:disable-next-line:ban-types - T[K] extends Function ? T[K] : T[K] | null; + >]: T[K] extends Function ? T[K] : T[K] | null; // tslint:disable-line:ban-types }; - interface PartialDMChannel extends Partialize { + interface PartialDMChannel + extends Partialize< + DMChannel, + 'lastMessage' | 'lastMessageID' | 'messages' | 'recipient' | 'type' | 'typing' | 'typingCount' + > { lastMessage: null; lastMessageID: undefined; messages: MessageManager; @@ -2820,16 +2815,11 @@ declare module 'discord.js' { }[]; } - interface PartialGuildMember extends Partialize { + interface PartialGuildMember + extends Partialize< + GuildMember, + 'bannable' | 'displayColor' | 'displayHexColor' | 'displayName' | 'guild' | 'kickable' | 'permissions' | 'roles' + > { readonly bannable: boolean; readonly displayColor: number; readonly displayHexColor: string; @@ -2842,16 +2832,11 @@ declare module 'discord.js' { readonly roles: GuildMember['roles']; } - interface PartialMessage extends Partialize { + interface PartialMessage + extends Partialize< + Message, + 'attachments' | 'channel' | 'deletable' | 'editable' | 'mentions' | 'pinnable' | 'system' | 'url' + > { attachments: Message['attachments']; channel: Message['channel']; readonly deletable: boolean;