From a3be0f3726af76420e20f2406c15b1813039b8ea Mon Sep 17 00:00:00 2001 From: Dim Date: Sun, 14 Jan 2018 08:28:00 -0500 Subject: [PATCH 1/3] docs: Collection > RoleStore (#2251) --- src/structures/Guild.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/structures/Guild.js b/src/structures/Guild.js index 977e7b463..a75829313 100644 --- a/src/structures/Guild.js +++ b/src/structures/Guild.js @@ -40,7 +40,7 @@ class Guild extends Base { /** * A collection of roles that are in this guild. The key is the role's ID, the value is the role - * @type {Collection} + * @type {RoleStore} */ this.roles = new RoleStore(this); From 351f5f72091686ee94c9e1bbcb1e66fb65595b72 Mon Sep 17 00:00:00 2001 From: Dim Date: Sun, 14 Jan 2018 08:28:46 -0500 Subject: [PATCH 2/3] fix: missing height & width in embeds (#2249) --- src/structures/MessageEmbed.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/structures/MessageEmbed.js b/src/structures/MessageEmbed.js index b7f430b75..9c8271372 100644 --- a/src/structures/MessageEmbed.js +++ b/src/structures/MessageEmbed.js @@ -67,8 +67,8 @@ class MessageEmbed { this.thumbnail = data.thumbnail ? { url: data.thumbnail.url, proxyURL: data.thumbnail.proxy_url, - height: data.height, - width: data.width, + height: data.thumbnail.height, + width: data.thumbnail.width, } : null; /** @@ -82,8 +82,8 @@ class MessageEmbed { this.image = data.image ? { url: data.image.url, proxyURL: data.image.proxy_url, - height: data.height, - width: data.width, + height: data.image.height, + width: data.image.width, } : null; /** From 42c0e50c92d28dca78057907d89d4df576daedf2 Mon Sep 17 00:00:00 2001 From: pedall Date: Sun, 14 Jan 2018 20:46:08 +0100 Subject: [PATCH 3/3] Fix ShardClientUtil#broadcastEval - now really accepting functions (#2248) * small fix to broadcastEval accepting functions * dont ignore idea anymore (separate PR then) --- src/sharding/ShardClientUtil.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sharding/ShardClientUtil.js b/src/sharding/ShardClientUtil.js index 1c47f0296..8b8262150 100644 --- a/src/sharding/ShardClientUtil.js +++ b/src/sharding/ShardClientUtil.js @@ -86,7 +86,7 @@ class ShardClientUtil { */ broadcastEval(script) { return new Promise((resolve, reject) => { - script = typeof script !== 'function' ? `(${script})(this)` : script; + script = typeof script === 'function' ? `(${script})(this)` : script; const listener = message => { if (!message || message._sEval !== script) return; process.removeListener('message', listener);