From f95f18b586069bb40ebe027c4a014a0263190641 Mon Sep 17 00:00:00 2001 From: SpaceEEC Date: Tue, 9 May 2017 00:19:24 +0200 Subject: [PATCH] Handing promise rejections from GuildAuditLogs#build to the user (#1474) * handing guildauditlog's promise rejections to the user * Returning a new Promise to resolve a Promise.all is unnecessary. Also for the docs, it returns a Promise, not GuildAuditLogs directly. * totally did not removed that line --- src/structures/GuildAuditLogs.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/structures/GuildAuditLogs.js b/src/structures/GuildAuditLogs.js index e53126edd..9202ed231 100644 --- a/src/structures/GuildAuditLogs.js +++ b/src/structures/GuildAuditLogs.js @@ -62,13 +62,11 @@ class GuildAuditLogs { /** * Handles possible promises for entry targets. - * @returns {GuildAuditLogs} + * @returns {Promise} */ static build(...args) { - return new Promise(resolve => { - const logs = new GuildAuditLogs(...args); - Promise.all(logs.entries.map(e => e.target)).then(() => resolve(logs)); - }); + const logs = new GuildAuditLogs(...args); + return Promise.all(logs.entries.map(e => e.target)).then(() => logs); } /**