From fcf7f27fd78b6de9b67c3758899e0abfab3af774 Mon Sep 17 00:00:00 2001 From: Denis-Adrian Cristea Date: Wed, 8 Oct 2025 13:33:51 +0300 Subject: [PATCH] ci(release): handling for create-discord-app (#11143) * ci(release): handling for create-discord-app * ci(deprecate): cda support * ci: update our custom action to handle the renaming when invoked * fix: don't double release on github * chore: just in case --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> --- .github/workflows/deprecate-version.yml | 1 + .../actions/src/releasePackages/releasePackage.ts | 13 +++++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/.github/workflows/deprecate-version.yml b/.github/workflows/deprecate-version.yml index 328f67dab..8766e3321 100644 --- a/.github/workflows/deprecate-version.yml +++ b/.github/workflows/deprecate-version.yml @@ -11,6 +11,7 @@ on: - '@discordjs/builders' - '@discordjs/collection' - '@discordjs/core' + - 'create-discord-app' - 'create-discord-bot' - '@discordjs/formatters' - 'discord.js' diff --git a/packages/actions/src/releasePackages/releasePackage.ts b/packages/actions/src/releasePackages/releasePackage.ts index 7892264fe..6b911136b 100644 --- a/packages/actions/src/releasePackages/releasePackage.ts +++ b/packages/actions/src/releasePackages/releasePackage.ts @@ -41,7 +41,7 @@ async function gitTagAndRelease(release: ReleaseEntry, dry: boolean) { } } -export async function releasePackage(release: ReleaseEntry, dev: boolean, dry: boolean) { +export async function releasePackage(release: ReleaseEntry, dev: boolean, dry: boolean, doGitRelease = !dev) { // Sanity check against the registry first if (await checkRegistry(release)) { info(`${release.name}@${release.version} already published, skipping.`); @@ -54,7 +54,8 @@ export async function releasePackage(release: ReleaseEntry, dev: boolean, dry: b await $`pnpm --filter=${release.name} publish --provenance --no-git-checks ${dev ? '--tag=dev' : ''}`; } - if (!dev) await gitTagAndRelease(release, dry); + // && !dev just to be sure + if (doGitRelease && !dev) await gitTagAndRelease(release, dry); if (dry) return; @@ -83,4 +84,12 @@ export async function releasePackage(release: ReleaseEntry, dev: boolean, dry: b // eslint-disable-next-line promise/prefer-await-to-then .then(() => {}); } + + // Evil, but I can't think of a cleaner mechanism + if (release.name === 'create-discord-bot') { + await $`pnpm --filter=create-discord-bot run rename-to-app`; + // eslint-disable-next-line require-atomic-updates + release.name = 'create-discord-app'; + await releasePackage(release, dev, dry, false); + } }