Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-15 11:03:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Using a traditional for loop rather than a for in loop for options.files (#1461)

Browse Source
This commit is contained in:
Crawl
2017-05-06 01:14:27 +02:00
parent 1e115efa56
commit fd7cb41ee6
2 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/structures/Webhook.js
View File

@@ -105,14 +105,22 @@ class Webhook {
options = {}; options = {};
} }
if (options.file) { if (options.file) {
if (typeof options.file === 'string') options.file = { attachment: options.file }; if (options.files) options.files.push(options.file);
if (!options.file.name) { else options.files = [options.file];
if (typeof options.file.attachment === 'string') { }
options.file.name = path.basename(options.file.attachment);
} else if (options.file.attachment && options.file.attachment.path) { if (options.files) {
options.file.name = path.basename(options.file.attachment.path); for (let i = 0; i < options.files.length; i++) {
} else { let file = options.files[i];
options.file.name = 'file.jpg'; if (typeof file === 'string') file = { attachment: file };
if (!file.name) {
if (typeof file.attachment === 'string') {
file.name = path.basename(file.attachment);
} else if (file.attachment && file.attachment.path) {
file.name = path.basename(file.attachment.path);
} else {
file.name = 'file.jpg';
}
} }
} }
return this.client.resolver.resolveBuffer(options.file.attachment).then(file => return this.client.resolver.resolveBuffer(options.file.attachment).then(file =>

2
src/structures/interfaces/TextBasedChannel.js
View File

@@ -88,7 +88,7 @@ class TextBasedChannel {
} }
if (options.files) { if (options.files) {
for (const i in options.files) { for (let i = 0; i < options.files.length; i++) {
let file = options.files[i]; let file = options.files[i];
if (typeof file === 'string') file = { attachment: file }; if (typeof file === 'string') file = { attachment: file };
if (!file.name) { if (!file.name) {