Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-14 02:23:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make all VoiceChannel bitrates in bps (#2165)

Browse Source 
* Make all VoiceChannel bitrates in bps

instead of mixed kbps/bps

* fix edit method in GuildChannel too
This commit is contained in:
bdistin
2017-12-11 22:02:53 -06:00
committed by Crawl
parent 96971c432d
commit fe9ea02f8b
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/structures/GuildChannel.js
View File

@@ -292,7 +292,7 @@ class GuildChannel extends Channel {
name: (data.name || this.name).trim(), name: (data.name || this.name).trim(),
topic: data.topic, topic: data.topic,
nsfw: data.nsfw, nsfw: data.nsfw,
bitrate: data.bitrate || (this.bitrate ? this.bitrate * 1000 : undefined), bitrate: data.bitrate || this.bitrate,
user_limit: typeof data.userLimit !== 'undefined' ? data.userLimit : this.userLimit, user_limit: typeof data.userLimit !== 'undefined' ? data.userLimit : this.userLimit,
parent_id: data.parentID, parent_id: data.parentID,
lock_permissions: data.lockPermissions, lock_permissions: data.lockPermissions,

9
src/structures/VoiceChannel.js
View File

@@ -25,7 +25,7 @@ class VoiceChannel extends GuildChannel {
* The bitrate of this voice channel * The bitrate of this voice channel
* @type {number} * @type {number}
*/ */
this.bitrate = data.bitrate * 0.001; this.bitrate = data.bitrate;
/** /**
* The maximum amount of users allowed in this channel - 0 means unlimited. * The maximum amount of users allowed in this channel - 0 means unlimited.
@@ -76,18 +76,17 @@ class VoiceChannel extends GuildChannel {
} }
/** /**
* Sets the bitrate of the channel (in kbps). * Sets the bitrate of the channel.
* @param {number} bitrate The new bitrate * @param {number} bitrate The new bitrate
* @param {string} [reason] Reason for changing the channel's bitrate * @param {string} [reason] Reason for changing the channel's bitrate
* @returns {Promise<VoiceChannel>} * @returns {Promise<VoiceChannel>}
* @example * @example
* // Set the bitrate of a voice channel * // Set the bitrate of a voice channel
* voiceChannel.setBitrate(48) * voiceChannel.setBitrate(48000)
* .then(vc => console.log(`Set bitrate to ${vc.bitrate}kbps for ${vc.name}`)) * .then(vc => console.log(`Set bitrate to ${vc.bitrate}bps for ${vc.name}`))
* .catch(console.error); * .catch(console.error);
*/ */
setBitrate(bitrate, reason) { setBitrate(bitrate, reason) {
bitrate *= 1000;
return this.edit({ bitrate }, reason); return this.edit({ bitrate }, reason);
} }