From ff3e602134601a0d5e729a4c117f52c039eedfef Mon Sep 17 00:00:00 2001 From: SpaceEEC Date: Fri, 12 May 2017 15:30:46 +0200 Subject: [PATCH] Failing to resolve a role should reject and not throw an error (#1483) --- src/structures/GuildMember.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/structures/GuildMember.js b/src/structures/GuildMember.js index bcad0e03e..0c096120d 100644 --- a/src/structures/GuildMember.js +++ b/src/structures/GuildMember.js @@ -394,7 +394,7 @@ class GuildMember { */ addRole(role) { if (!(role instanceof Role)) role = this.guild.roles.get(role); - if (!role) throw new TypeError('Supplied parameter was neither a Role nor a Snowflake.'); + if (!role) return Promise.reject(new TypeError('Supplied parameter was neither a Role nor a Snowflake.')); return this.client.rest.methods.addMemberRole(this, role); } @@ -421,7 +421,7 @@ class GuildMember { */ removeRole(role) { if (!(role instanceof Role)) role = this.guild.roles.get(role); - if (!role) throw new TypeError('Supplied parameter was neither a Role nor a Snowflake.'); + if (!role) return Promise.reject(new TypeError('Supplied parameter was neither a Role nor a Snowflake.')); return this.client.rest.methods.removeMemberRole(this, role); }