fix sequential and burst ratelimiters from going on timeout because the queue is empty (#1722)

* create branch for me to work on

* fix sequential and burst ratelimiters from going on timeout because the queue is empty
This commit is contained in:
bdistin
2017-07-26 19:51:58 -05:00
committed by Crawl
parent 8bd7b82110
commit 080996b5a9
3 changed files with 3 additions and 3 deletions

View File

@@ -14,7 +14,7 @@ class RequestHandler {
}
get limited() {
return this.queue.length === 0 || this.manager.globallyRateLimited || this.remaining <= 0;
return this.manager.globallyRateLimited || this.remaining <= 0;
}
set globallyLimited(limited) {

View File

@@ -1,5 +1,5 @@
module.exports = function burst() {
if (this.limited) return;
if (this.limited || this.queue.length === 0) return;
this.execute(this.queue.shift())
.then(this.handle.bind(this))
.catch(({ timeout }) => {

View File

@@ -1,5 +1,5 @@
module.exports = function sequential() {
if (this.busy || this.limited) return;
if (this.busy || this.limited || this.queue.length === 0) return;
this.busy = true;
this.execute(this.queue.shift())
.then(() => {