Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-15 19:13:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat(Collector): yield all collected values (#7073)

Browse Source
This commit is contained in:
Antonio Román
2022-01-07 23:39:49 +01:00
committed by GitHub
parent b454740ae8
commit 2b480cb14e
3 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/discord.js/src/structures/interfaces/Collector.js
View File

@@ -236,7 +236,7 @@ class Collector extends EventEmitter {
*/ */
async *[Symbol.asyncIterator]() { async *[Symbol.asyncIterator]() {
const queue = []; const queue = [];
const onCollect = item => queue.push(item); const onCollect = (...item) => queue.push(item);
this.on('collect', onCollect); this.on('collect', onCollect);
try { try {

2
packages/discord.js/typings/index.d.ts vendored
View File

@@ -670,7 +670,7 @@ export abstract class Collector<K, V, F extends unknown[] = []> extends EventEmi
public handleDispose(...args: unknown[]): Promise<void>; public handleDispose(...args: unknown[]): Promise<void>;
public stop(reason?: string): void; public stop(reason?: string): void;
public resetTimer(options?: CollectorResetTimerOptions): void; public resetTimer(options?: CollectorResetTimerOptions): void;
public [Symbol.asyncIterator](): AsyncIterableIterator<V>; public [Symbol.asyncIterator](): AsyncIterableIterator<[V, ...F]>;
public toJSON(): unknown; public toJSON(): unknown;
protected listener: (...args: any[]) => void; protected listener: (...args: any[]) => void;

18
packages/discord.js/typings/index.test-d.ts
View File

@@ -794,11 +794,23 @@ messageCollector.on('collect', (...args) => {
expectType<[Message]>(args); expectType<[Message]>(args);
}); });
(async () => {
for await (const value of messageCollector) {
expectType<[Message<boolean>]>(value);
}
})();
declare const reactionCollector: ReactionCollector; declare const reactionCollector: ReactionCollector;
reactionCollector.on('dispose', (...args) => { reactionCollector.on('dispose', (...args) => {
expectType<[MessageReaction, User]>(args); expectType<[MessageReaction, User]>(args);
}); });
(async () => {
for await (const value of reactionCollector) {
expectType<[MessageReaction, User]>(value);
}
})();
// Make sure the properties are typed correctly, and that no backwards properties // Make sure the properties are typed correctly, and that no backwards properties
// (K -> V and V -> K) exist: // (K -> V and V -> K) exist:
expectType<'messageCreate'>(Constants.Events.MESSAGE_CREATE); expectType<'messageCreate'>(Constants.Events.MESSAGE_CREATE);
@@ -1169,6 +1181,12 @@ collector.on('end', (collection, reason) => {
expectType<string>(reason); expectType<string>(reason);
}); });
(async () => {
for await (const value of collector) {
expectType<[Interaction, ...string[]]>(value);
}
})();
expectType<Promise<number | null>>(shard.eval(c => c.readyTimestamp)); expectType<Promise<number | null>>(shard.eval(c => c.readyTimestamp));
// Test audit logs // Test audit logs