feat(Actions): add parent structure to events parameters (#7577)

This commit is contained in:
Synbulat Biishev
2022-04-09 14:35:55 +05:00
committed by GitHub
parent 6fec25239d
commit 3f3e4327c8
5 changed files with 11 additions and 9 deletions

View File

@@ -33,8 +33,9 @@ class MessageDeleteBulkAction extends Action {
* Emitted whenever messages are deleted in bulk.
* @event Client#messageDeleteBulk
* @param {Collection<Snowflake, Message>} messages The deleted messages, mapped by their id
* @param {TextBasedChannels} channel The channel that the messages were deleted in
*/
if (messages.size > 0) client.emit(Events.MessageBulkDelete, messages);
if (messages.size > 0) client.emit(Events.MessageBulkDelete, messages, channel);
return { messages };
}
return {};

View File

@@ -39,8 +39,9 @@ class ThreadListSyncAction extends Action {
* Emitted whenever the client user gains access to a text or news channel that contains threads
* @event Client#threadListSync
* @param {Collection<Snowflake, ThreadChannel>} threads The threads that were synced
* @param {Guild} guild The guild that the threads were synced in
*/
client.emit(Events.ThreadListSync, syncedThreads);
client.emit(Events.ThreadListSync, syncedThreads, guild);
return {
syncedThreads,

View File

@@ -33,11 +33,11 @@ class ThreadMembersUpdateAction extends Action {
/**
* Emitted whenever members are added or removed from a thread. Requires `GUILD_MEMBERS` privileged intent
* @event Client#threadMembersUpdate
* @param {ThreadChannel} thread The thread where members got updated
* @param {Collection<Snowflake, ThreadMember>} addedMembers The members that were added
* @param {Collection<Snowflake, ThreadMember>} removedMembers The members that were removed
* @param {ThreadChannel} thread The thread where members got updated
*/
client.emit(Events.ThreadMembersUpdate, thread, addedMembers, removedMembers);
client.emit(Events.ThreadMembersUpdate, addedMembers, removedMembers, thread);
}
return {};
}

View File

@@ -3740,7 +3740,7 @@ export interface ClientEvents {
reactions: Collection<string | Snowflake, MessageReaction>,
];
messageReactionRemoveEmoji: [reaction: MessageReaction | PartialMessageReaction];
messageDeleteBulk: [messages: Collection<Snowflake, Message | PartialMessage>];
messageDeleteBulk: [messages: Collection<Snowflake, Message | PartialMessage>, channel: TextBasedChannel];
messageReactionAdd: [reaction: MessageReaction | PartialMessageReaction, user: User | PartialUser];
messageReactionRemove: [reaction: MessageReaction | PartialMessageReaction, user: User | PartialUser];
messageUpdate: [oldMessage: Message | PartialMessage, newMessage: Message | PartialMessage];
@@ -3752,12 +3752,12 @@ export interface ClientEvents {
roleUpdate: [oldRole: Role, newRole: Role];
threadCreate: [thread: ThreadChannel, newlyCreated: boolean];
threadDelete: [thread: ThreadChannel];
threadListSync: [threads: Collection<Snowflake, ThreadChannel>];
threadListSync: [threads: Collection<Snowflake, ThreadChannel>, guild: Guild];
threadMemberUpdate: [oldMember: ThreadMember, newMember: ThreadMember];
threadMembersUpdate: [
thread: ThreadChannel,
addedMembers: Collection<Snowflake, ThreadMember>,
removedMembers: Collection<Snowflake, ThreadMember | PartialThreadMember>,
thread: ThreadChannel,
];
threadUpdate: [oldThread: ThreadChannel, newThread: ThreadChannel];
typingStart: [typing: Typing];

View File

@@ -762,10 +762,10 @@ client.on('messageCreate', async message => {
channel.send({ components: [row, buttonsRow, selectsRow], embeds: [embed, buildersEmbed, embedData] });
});
client.on('threadMembersUpdate', (thread, addedMembers, removedMembers) => {
expectType<ThreadChannel>(thread);
client.on('threadMembersUpdate', (addedMembers, removedMembers, thread) => {
expectType<Collection<Snowflake, ThreadMember>>(addedMembers);
expectType<Collection<Snowflake, ThreadMember | PartialThreadMember>>(removedMembers);
expectType<ThreadChannel>(thread);
const left = removedMembers.first();
if (!left) return;