Failing to resolve a role should reject and not throw an error (#1483)

This commit is contained in:
SpaceEEC
2017-05-12 15:30:46 +02:00
committed by Crawl
parent e3c3a4fd60
commit 45bc653988

View File

@@ -394,7 +394,7 @@ class GuildMember {
*/
addRole(role) {
if (!(role instanceof Role)) role = this.guild.roles.get(role);
if (!role) throw new TypeError('Supplied parameter was neither a Role nor a Snowflake.');
if (!role) return Promise.reject(new TypeError('Supplied parameter was neither a Role nor a Snowflake.'));
return this.client.rest.methods.addMemberRole(this, role);
}
@@ -421,7 +421,7 @@ class GuildMember {
*/
removeRole(role) {
if (!(role instanceof Role)) role = this.guild.roles.get(role);
if (!role) throw new TypeError('Supplied parameter was neither a Role nor a Snowflake.');
if (!role) return Promise.reject(new TypeError('Supplied parameter was neither a Role nor a Snowflake.'));
return this.client.rest.methods.removeMemberRole(this, role);
}