Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-10 08:33:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Cache array and keyArray in Collection (#771)

Browse Source 
* Cache array and keyArray in Collection

Cache array and keyArray in the Collection class to improve consecutive
calls of collection.random() by around 400,000%, I think lel.

The speed decrease (I assume) compared to the previous version when
calling after it has changed is most likely negligible.

* Fix for ESLint

I think this fixes it.
This commit is contained in:
Slamakans
2016-10-05 00:53:26 +02:00
committed by Schuyler Cebulskie
parent 2acfb16cb8
commit 53f5c2cb52
1 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/util/Collection.js
View File

@@ -3,6 +3,16 @@
* @extends {Map}
*/
class Collection extends Map {
set(key, value) {
super.set(key, value);
this.changed = true;
}
delete(key) {
super.delete(key);
this.changed = true;
}
/**
* Returns an ordered array of the values of this collection.
* @returns {Array}
@@ -67,8 +77,11 @@ class Collection extends Map {
* @returns {*}
*/
random() {
const arr = this.array();
return arr[Math.floor(Math.random() * arr.length)];
if (!this.cachedArray || this.cachedArray.length !== this.size || this.changed) {
this.cachedArray = this.array();
this.changed = false;
}
return this.cachedArray[Math.floor(Math.random() * this.cachedArray.length)];
}
/**
@@ -77,8 +90,11 @@ class Collection extends Map {
* @returns {*}
*/
randomKey() {
const arr = this.keyArray();
return arr[Math.floor(Math.random() * arr.length)];
if (!this.cachedKeyArray || this.cachedKeyArray.length !== this.size || this.changed) {
this.cachedKeyArray = this.keyArray();
this.changed = false;
}
return this.cachedKeyArray[Math.floor(Math.random() * this.cachedKeyArray.length)];
}
/**