fix: remove for..in in favor of Object.keys (#3745)

src/client/rest/RESTMethods.js

@@ -238,7 +238,7 @@ class RESTMethods {
       include_nsfw: options.nsfw,
     };
 
-    for (const key in options) if (options[key] === undefined) delete options[key];
+    for (const key of Object.keys(options)) if (options[key] === undefined) delete options[key];
     const queryString = (querystring.stringify(options).match(/[^=&?]+=[^=&?]+/g) || []).join('&');
 
     let endpoint;

src/client/voice/util/SecretKey.js

@@ -9,7 +9,7 @@ class SecretKey {
      * @type {Uint8Array}
      */
     this.key = new Uint8Array(new ArrayBuffer(key.length));
-    for (const index in key) this.key[index] = key[index];
+    for (const index of Object.keys(key)) this.key[index] = key[index];
   }
 }
 

src/client/websocket/packets/handlers/Ready.js

@@ -36,7 +36,7 @@ class ReadyHandler extends AbstractHandler {
     }
 
     if (data.notes) {
-      for (const user in data.notes) {
+      for (const user of Object.keys(data.notes)) {
         let note = data.notes[user];
         if (!note.length) note = null;
 

src/structures/GuildChannel.js

@@ -258,7 +258,7 @@ class GuildChannel extends Channel {
       payload.deny = prevOverwrite.deny;
     }
 
-    for (const perm in options) {
+    for (const perm of Object.keys(options)) {
       if (options[perm] === true) {
         payload.allow |= Permissions.FLAGS[perm] || 0;
         payload.deny &= ~(Permissions.FLAGS[perm] || 0);

src/util/Permissions.js

@@ -126,7 +126,7 @@ class Permissions {
    */
   serialize(checkAdmin = true) {
     const serialized = {};
-    for (const perm in this.constructor.FLAGS) serialized[perm] = this.has(perm, checkAdmin);
+    for (const perm of Object.keys(this.constructor.FLAGS)) serialized[perm] = this.has(perm, checkAdmin);
     return serialized;
   }