Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-15 19:13:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove for..in in favor of Object.keys (#3745)

Browse Source
This commit is contained in:
SpaceEEC
2020-01-31 12:38:47 +01:00
committed by GitHub
parent ab7f9e80b4
commit 6d7e1e4953
5 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/client/rest/RESTMethods.js
View File

@@ -238,7 +238,7 @@ class RESTMethods {
include_nsfw: options.nsfw, include_nsfw: options.nsfw,
}; };
for (const key in options) if (options[key] === undefined) delete options[key]; for (const key of Object.keys(options)) if (options[key] === undefined) delete options[key];
const queryString = (querystring.stringify(options).match(/[^=&?]+=[^=&?]+/g) || []).join('&'); const queryString = (querystring.stringify(options).match(/[^=&?]+=[^=&?]+/g) || []).join('&');
let endpoint; let endpoint;

2
src/client/voice/util/SecretKey.js
View File

@@ -9,7 +9,7 @@ class SecretKey {
* @type {Uint8Array} * @type {Uint8Array}
*/ */
this.key = new Uint8Array(new ArrayBuffer(key.length)); this.key = new Uint8Array(new ArrayBuffer(key.length));
for (const index in key) this.key[index] = key[index]; for (const index of Object.keys(key)) this.key[index] = key[index];
} }
} }

2
src/client/websocket/packets/handlers/Ready.js
View File

@@ -36,7 +36,7 @@ class ReadyHandler extends AbstractHandler {
} }
if (data.notes) { if (data.notes) {
for (const user in data.notes) { for (const user of Object.keys(data.notes)) {
let note = data.notes[user]; let note = data.notes[user];
if (!note.length) note = null; if (!note.length) note = null;

2
src/structures/GuildChannel.js
View File

@@ -258,7 +258,7 @@ class GuildChannel extends Channel {
payload.deny = prevOverwrite.deny; payload.deny = prevOverwrite.deny;
} }
for (const perm in options) { for (const perm of Object.keys(options)) {
if (options[perm] === true) { if (options[perm] === true) {
payload.allow |= Permissions.FLAGS[perm] || 0; payload.allow |= Permissions.FLAGS[perm] || 0;
payload.deny &= ~(Permissions.FLAGS[perm] || 0); payload.deny &= ~(Permissions.FLAGS[perm] || 0);

2
src/util/Permissions.js
View File

@@ -126,7 +126,7 @@ class Permissions {
*/ */
serialize(checkAdmin = true) { serialize(checkAdmin = true) {
const serialized = {}; const serialized = {};
for (const perm in this.constructor.FLAGS) serialized[perm] = this.has(perm, checkAdmin); for (const perm of Object.keys(this.constructor.FLAGS)) serialized[perm] = this.has(perm, checkAdmin);
return serialized; return serialized;
} }