fix(rest): sublimit all requests on unhandled routes (#7366)

This commit is contained in:
ckohen
2022-02-05 05:30:55 -08:00
committed by GitHub
parent a7b80b9d9b
commit 733ac82d5d
2 changed files with 19 additions and 5 deletions

View File

@@ -166,7 +166,7 @@ nock(`${DefaultRestOptions.api}/v${DefaultRestOptions.version}`)
];
})
.get('/unexpected')
.times(2)
.times(3)
.reply((): nock.ReplyFnResult => {
if (unexpected429) {
unexpected429 = false;
@@ -310,9 +310,22 @@ test('Handle sublimits', async () => {
});
test('Handle unexpected 429', async () => {
const previous = Date.now();
expect(await api.get('/unexpected')).toStrictEqual({ test: true });
expect(Date.now()).toBeGreaterThanOrEqual(previous + 1000);
const previous = performance.now();
let firstResolvedTime: number;
let secondResolvedTime: number;
const unexepectedSublimit = api.get('/unexpected').then((res) => {
firstResolvedTime = performance.now();
return res;
});
const queuedSublimit = api.get('/unexpected').then((res) => {
secondResolvedTime = performance.now();
return res;
});
expect(await unexepectedSublimit).toStrictEqual({ test: true });
expect(await queuedSublimit).toStrictEqual({ test: true });
expect(performance.now()).toBeGreaterThanOrEqual(previous + 1000);
expect(secondResolvedTime).toBeGreaterThan(firstResolvedTime);
});
test('Handle unexpected 429 cloudflare', async () => {

View File

@@ -33,5 +33,6 @@ export function hasSublimit(bucketRoute: string, body?: unknown, method?: string
return ['name', 'topic'].some((key) => Reflect.has(castedBody, key));
}
return false;
// If we are checking if a request has a sublimit on a route not checked above, sublimit all requests to avoid a flood of 429s
return true;
}