Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-16 03:23:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: Role#setPermissions resolving & docs

Browse Source
This commit is contained in:
Lewdcario
2018-04-18 19:57:16 -05:00
parent 92b421607e
commit 7c0b6173dd
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/client/rest/RESTMethods.js
View File

@@ -632,7 +632,7 @@ class RESTMethods {
data.hoist = typeof _data.hoist !== 'undefined' ? _data.hoist : role.hoist; data.hoist = typeof _data.hoist !== 'undefined' ? _data.hoist : role.hoist;
data.mentionable = typeof _data.mentionable !== 'undefined' ? _data.mentionable : role.mentionable; data.mentionable = typeof _data.mentionable !== 'undefined' ? _data.mentionable : role.mentionable;
if (_data.permissions) data.permissions = Permissions.resolve(_data.permissions); if (typeof _data.permissions !== 'undefined') data.permissions = Permissions.resolve(_data.permissions);
else data.permissions = role.permissions; else data.permissions = role.permissions;
return this.rest.makeRequest('patch', Endpoints.Guild(role.guild).Role(role.id), true, data, undefined, reason) return this.rest.makeRequest('patch', Endpoints.Guild(role.guild).Role(role.id), true, data, undefined, reason)

2
src/structures/Role.js
View File

@@ -276,7 +276,7 @@ class Role {
/** /**
* Set the permissions of the role. * Set the permissions of the role.
* @param {string[]} permissions The permissions of the role * @param {PermissionResolvable|PermissionResolvable[]} permissions The permissions of the role
* @param {string} [reason] Reason for changing the role's permissions * @param {string} [reason] Reason for changing the role's permissions
* @returns {Promise<Role>} * @returns {Promise<Role>}
* @example * @example

2
src/util/Permissions.js
View File

@@ -165,7 +165,7 @@ class Permissions {
static resolve(permission) { static resolve(permission) {
if (permission instanceof Array) return permission.map(p => this.resolve(p)).reduce((prev, p) => prev | p, 0); if (permission instanceof Array) return permission.map(p => this.resolve(p)).reduce((prev, p) => prev | p, 0);
if (typeof permission === 'string') permission = this.FLAGS[permission]; if (typeof permission === 'string') permission = this.FLAGS[permission];
if (typeof permission !== 'number' || permission < 1) throw new RangeError(Constants.Errors.NOT_A_PERMISSION); if (typeof permission !== 'number' || permission < 0) throw new RangeError(Constants.Errors.NOT_A_PERMISSION);
return permission; return permission;
} }
} }