Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-16 11:33:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Throw Error for non role-resolvables (#1322)

Browse Source 
* throw error for role names/integers being provided for role resolvables

* Update RESTMethods.js

* Update RESTMethods.js

im really bad

* Update RESTMethods.js

* removed new promise reject

ty gus

* Update RESTMethods.js

* move error to guildmember.addRole method

* Update GuildMember.js
This commit is contained in:
Isabella
2017-04-19 11:57:54 -05:00
committed by Crawl
parent ca34c43ba0
commit a652901d60
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/structures/GuildMember.js
View File

@@ -393,6 +393,7 @@ class GuildMember {
*/ */
addRole(role) { addRole(role) {
if (!(role instanceof Role)) role = this.guild.roles.get(role); if (!(role instanceof Role)) role = this.guild.roles.get(role);
if (!role) throw new TypeError('Supplied parameter was neither a Role nor a Snowflake.');
return this.client.rest.methods.addMemberRole(this, role); return this.client.rest.methods.addMemberRole(this, role);
} }
@@ -419,6 +420,7 @@ class GuildMember {
*/ */
removeRole(role) { removeRole(role) {
if (!(role instanceof Role)) role = this.guild.roles.get(role); if (!(role instanceof Role)) role = this.guild.roles.get(role);
if (!role) throw new TypeError('Supplied parameter was neither a Role nor a Snowflake.');
return this.client.rest.methods.removeMemberRole(this, role); return this.client.rest.methods.removeMemberRole(this, role);
} }